[PATCH] D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase

Wed Feb 17 21:25:50 PST 2021

TaoPan added a comment.

In D96393#2570472 <https://reviews.llvm.org/D96393#2570472>, @snehasish wrote:

> Please do not merge this test. Apologies if I was unclear earlier - there is no need for this test since the functionality is already tested in test/DebugInfo/X86/basic-block-sections_1.ll
> The machine function splitter (MFS) pass uses basic block sections so if the dwarf debug info generated by basic block sections is correct then MFS is also correct.

Thanks! I got it's MFS dependent basic block sections ensure dwarf debug info correct.
As for Windows COFF, is it also not MFS but MFS dependent basic block sections may be incorrect for Windows native debuggers, so need to extend basic block sections debug info test at first?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96393/new/

https://reviews.llvm.org/D96393