[PATCH] D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase

Wed Feb 17 20:33:35 PST 2021

snehasish added a comment.

In D96393#2570438 <https://reviews.llvm.org/D96393#2570438>, @TaoPan wrote:

> Thanks for reminding the discussion of not adding a separate debug info test for function splitting! I’ll merge the test into test/DebugInfo/X86/basic-block-sections_1.ll.

Please do not merge this test. Apologies if I was unclear earlier - there is no need for this test since the functionality is already tested in test/DebugInfo/X86/basic-block-sections_1.ll
The machine function splitter (MFS) pass uses basic block sections so if the dwarf debug info generated by basic block sections is correct then MFS is also correct.

> Thanks for sharing information of dwarf, PE/COFF, CodeView, cygwin and Windows native debuggers! I think
>
>   add dwarf based test for Linux and Windows Cygwin
>
> is independent on
>
>   (refer to your shared information and existing test of test/DebugInfo/PDB/Native/ to) add CodeView based test for Windows native debuggers, it’s depends on #D95209, it’s better be added in #D95209.

Sounds good!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96393/new/

https://reviews.llvm.org/D96393