[PATCH] D96571: [ASan] Introduce a way set different ways of emitting module destructors.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizerOptions.h:11
+//===----------------------------------------------------------------------===//
+#ifndef LLVM_TRANSFORMS_INSTRUMENTATION_ADDRESSSANITIZER_OPTIONS_H
+#define LLVM_TRANSFORMS_INSTRUMENTATION_ADDRESSSANITIZER_OPTIONS_H
----------------
please fix clang-tidy


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizerOptions.h:13
+#define LLVM_TRANSFORMS_INSTRUMENTATION_ADDRESSSANITIZER_OPTIONS_H
+#include "llvm/ADT/StringRef.h"
+
----------------
unused include?


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2175
+  if (DestructorKind != AsanDtorKind::None) {
+    IRBuilder<> IRB_Dtor(CreateAsanModuleDtor(M));
+    IRB_Dtor.CreateCall(AsanUnregisterElfGlobals,
----------------
Please fix all clang-tidy


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2265
   // gets closed.
-  IRBuilder<> IRB_Dtor(CreateAsanModuleDtor(M));
-  IRB_Dtor.CreateCall(AsanUnregisterGlobals,
-                      {IRB.CreatePointerCast(AllGlobals, IntptrTy),
-                       ConstantInt::get(IntptrTy, N)});
+  if (DestructorKind != AsanDtorKind::None) {
+    IRBuilder<> IRB_Dtor(CreateAsanModuleDtor(M));
----------------
Can you check if some pre-existing tests fail if constructor accidentally initialized it to  AsanDtorKind::None)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96571/new/

https://reviews.llvm.org/D96571