[PATCH] D96746: [test-suite] SPEC2017 CPU ROMS floating point tests.

Nichols A. Romero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 14:18:54 PST 2021


naromero77 added a comment.

In D96746#2566172 <https://reviews.llvm.org/D96746#2566172>, @Meinersbur wrote:

> As far as I know, cmake detect module dependency itself, which would make `speccpu2017_add_mod` unnecessary.

It is not really clear from the CMake docs that it can figure out complex module dependencies without intermediary targets. Searching online, it looks like many Fortran-centric projects have come up with different solutions.

If the name of the macro is the issue, we can change it to something else besides `speccpu2017_add_mod`

> I applied the patch locally and change the compilation part to just `speccpu2017_add_executable()` and it still compiles.

Does it work for you if you at `make -j 10` or the equivalent with ninja? It is definitely failing to build for me when I increase the number of parallel builds due to missing `.mod` files.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96746/new/

https://reviews.llvm.org/D96746



More information about the llvm-commits mailing list