[PATCH] D96746: [test-suite] SPEC2017 CPU ROMS floating point tests.

Tue Feb 16 10:47:09 PST 2021

Meinersbur added a comment.

As far as I know, cmake detect module dependency itself, which would make `speccpu2017_add_mod` unnecessary.

I applied the patch locally and change the compilation part to just `speccpu2017_add_executable()` and it still works.

================
Comment at: External/SPEC/CFP2017rate/554.roms_r/CMakeLists.txt:48
+
+# fotonik3d has both relative and absolute tolerances
+speccpu2017_verify_output(RELATIVE_TOLERANCE 1.0e-7 ABSOLUTE_TOLERANCE 1.0e-7)
----------------
Leftover fotonik3d

================
Comment at: External/SPEC/CFP2017rate/554.roms_r/CMakeLists.txt:369
+# dependency on executable, will include transitive dependencies as well
+add_dependencies(${PROG} ${PROG}_Fortran_MOD_4)
+
----------------
Consider using target_link_libraries (https://cmake.org/cmake/help/latest/command/target_link_libraries.html#linking-object-libraries) for linking object libraries.

The tutorial uses generator expressions (`$<TARGET_OBJECTS:${PROG}_Fortran_MOD_4>`) which are missing here?

================
Comment at: External/SPEC/SpecCPU2017.cmake:342
+#
+# Some of the tests have a complex heirarchy of Fortran modules and
+# multiple USE statements.  The object files created by some modules
----------------
[typo] h**ei**rarchy 

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96746/new/

https://reviews.llvm.org/D96746