[PATCH] D95232: Symbolizer - Teach symbolizer to work directly on object file.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

>From my reads of the history of this component, I think DebugInfo/Symbolize was extracted from llvm-symbolizer because sanitizer runtime needs it. Later other LLVM internal tools (sanitizer runtime, sancov, sanstats, llvm-xray, etc) use the API as well.
I don't find usage from open-source projects. There could be, but I speculate that if do some refactoring the friction will be small.

Currently the `std::string` overloads are mainly used. It seems to me that we don't need to `std::string` overloads. They can likely all switch to the `const ObjectFile &` overloads.
I will take a stab at cleaning up the call sites.

@pvellien @scott.linder The concern with not testing the new API is that they are otherwise unused (I guess that you may have downstream projects which may adopt them soon) and may be deleted by other contributors as dead code.
If you have some specific use cases, contributing unittests would probably be a good idea.
I'll try refactoring the API, if `const std::string&` is replaced with `const ObjectFile &` overloads, then the API will be used by in-tree code and will be less likely deleted as dead code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95232/new/

https://reviews.llvm.org/D95232