[PATCH] D95232: Symbolizer - Teach symbolizer to work directly on object file.

[praveen velliengiri via Phabricator via llvm-commits]

pvellien added a comment.

In D95232#2566156 <https://reviews.llvm.org/D95232#2566156>, @dblaikie wrote:

> In D95232#2565937 <https://reviews.llvm.org/D95232#2565937>, @pvellien wrote:
>
>> In D95232#2564264 <https://reviews.llvm.org/D95232#2564264>, @dblaikie wrote:
>>
>>> Generally there should be test coverage - otherwise these APIs are likely to be cleaned up as unused, even if the chance of actual bugs in them is small (since they're just simple wrappers).
>>>
>>> Perhaps some unit testing would be suitable?
>>
>> Hi dave, thanks for your comments. I was worried about this thing. But there are no existing tools in llvm that work on object file directly expect there is a usage for one existing API - symbolizeCode.
>
> Sorry, I'm not quite following this last sentence, could you rephrase it?
>
> The first part (" But there are no existing tools in llvm that work on object file directly ") doesn't seem quite right, so far as I'm reading it - llvm-symbolizer, the command line tool, can operate on object files and many of the llvm-symbolizer tests operate on object files. (which also makes me wonder about this change in general - llvm-symbolizer can already work on object files, so why are new APIs required, given the functionality already exists/is used/tested?)
>
>> I don't know how it is reliable to add unit tests, I would highly appreciate your thoughts on this. thanks

Oh sorry, I mean an in-memory object file rather then a on-disk object file. This is similar to this patch : https://reviews.llvm.org/D63521 but it adds overloads for missing functions. Whether it helps? thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95232/new/

https://reviews.llvm.org/D95232