[PATCH] D96732: AMDGPU: Use kill instruction to hint soft clause live ranges

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:340
 
-      // Restore the state after processing the bundle.
-      RPT.reset(*B, &LiveRegsCopy);
-      DbgInstrs.clear();
+      SlotIndex BundleLiveInIdx = LIS->getInstructionIndex(MI);
+      SlotIndex BundleLiveOutIdx =
----------------
Since it is not a bundle anymore you probably want to use name "Clause" instead of "Bundle".


================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:345
+      // Collect the register operands we should extend the live ranges of.
+      SmallVector<std::tuple<Register, unsigned, unsigned>> KillOps;
 
----------------
You probably want to use a SetVector to avoid duplicate operands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96732/new/

https://reviews.llvm.org/D96732