[PATCH] D96013: GlobalISel: Try to combine G_[SU]DIV and G_[SU]REM

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 21:07:55 PST 2021


cdevadas updated this revision to Diff 323876.
cdevadas added a comment.

Reverting the recent changes to combine any matching extra div and rem instructions alongside the divrem instruction. The presence of the extra instruction shouldn't crash. Added tests to ensure that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96013/new/

https://reviews.llvm.org/D96013

Files:
  llvm/docs/GlobalISel/GenericOpcode.rst
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
  llvm/include/llvm/Support/TargetOpcodes.def
  llvm/include/llvm/Target/GenericOpcodes.td
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/postlegalizer-combiner-divrem.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/prelegalizer-combiner-divrem.mir
  llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96013.323876.patch
Type: text/x-patch
Size: 51426 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210216/3b1e330e/attachment-0001.bin>


More information about the llvm-commits mailing list