[PATCH] D96184: [AIX][TLS] Generate TLS variables in assembly files

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2068
+  if (GVKind.isCommon() || GVKind.isBSSLocal() ||
+      (GVKind.isThreadBSS() && !GV->hasExternalLinkage())) {
     Align Alignment = GV->getAlign().getValueOr(DL.getPreferredAlign(GV));
----------------
`!GV->hasExternalLinkage()` doesn't actually imply the symbol is local, we probably want something more like `isLocalLinkage()`

We should add some testcases for other non-local linkages like weak.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96184/new/

https://reviews.llvm.org/D96184