[PATCH] D96184: [AIX][TLS] Generate TLS variables in assembly files

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision as: sfertile.
sfertile added a comment.

LGTM. Please wait until David has given it the OK too though.



================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2164
+  // will get mapped into the .tbss section. Uninitialized external symbols are
+  // generated into the .tdata section.
+  if (Kind.isBSSLocal() || Kind.isCommon() ||
----------------
Maybe if you add a comment before `: XCOFF::XMC_UL;` clang-format will end up keeping a similar layout to what you already have. If not we should follow clang-format even though its inferior in this instance 😦 .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96184/new/

https://reviews.llvm.org/D96184