[PATCH] D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 10:45:55 PST 2021


MaskRay added a comment.

In D95916#2560392 <https://reviews.llvm.org/D95916#2560392>, @zatrazz wrote:

> This change broke arm32 llvm-symbolizer which triggered some sanitizer regression. Previously, ARM mapping symbols [1] were ignored but after this change they are shown as the function name.
>
> For instance:
>
>   $ ./bin/llvm-symbolizer --obj=projects/compiler-rt/test/asan/ARMHFLinuxConfig/TestCases/Output/invalid-pointer-pairs.cpp.tmp --functions 0xcbf48
>   f(char, char*, char*)
>   [...]/llvm/llvm-project/compiler-rt/test/asan/TestCases/invalid-pointer-pairs.cpp:17:14
>
> After this:
>
>   ./bin/llvm-symbolizer --obj=projects/compiler-rt/test/asan/ARMHFLinuxConfig/TestCases/Output/invalid-pointer-pairs.cpp.tmp --functions 0xcbf48
>   $a.2
>   /home/adhemerval.zanella/llvm/llvm-project/compiler-rt/test/asan/TestCases/invalid-pointer-pairs.cpp:17:14

Fix D96617 <https://reviews.llvm.org/D96617>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95916/new/

https://reviews.llvm.org/D95916



More information about the llvm-commits mailing list