[PATCH] D96143: [AMDGPU] Generate test checks and add GFX10 test coverage

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 00:28:31 PST 2021


critson accepted this revision.
critson added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/skip-if-dead.ll:352
   %cmp.var = fcmp olt float %var, 0.0
+  ; TODO: We could do an early-exit here (the branch above is uniform!)
   call void @llvm.amdgcn.kill(i1 %cmp.var)
----------------
foad wrote:
> I moved this comment (and another instance below). Hopefully it still makes some kind of sense to someone?
This seems reasonable.  The comment actually gets to go away when D94746 is merged.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96143/new/

https://reviews.llvm.org/D96143



More information about the llvm-commits mailing list