[PATCH] D95094: [ShrinkWrap] Enable Shrinkwrapping on 32 and 64 bit AIX, and 64 bit ELF

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:305
 ; ENABLE: cmplwi 3, 0
-; ENABLE-NEXT: beq 0, .[[ELSE_LABEL:LBB[0-9_]+]]
+; ENABLE-LINUX-NEXT: beq 0, .[[ELSE_LABEL:LBB[0-9_]+]]
+; ENABLE-AIX: beq 0, L..[[ELSE_LABEL:BB[0-9_]+]]
----------------
These 2 checks should be combined:
`ENABLE-NEXT: beq 0, {{.*}}[[ELSE_LABEL:BB[0-9_]+]]`


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:312
 ;
-; DISABLE: std
-; DISABLE-NEXT: std
-; DISABLE: cmplwi 3, 0
-; DISABLE-NEXT: beq 0, .[[ELSE_LABEL:LBB[0-9_]+]]
+; DISABLE-LINUX: std
+; DISABLE-LINUX-NEXT: std
----------------
Similarly here we should not need to differentiate based on target OS. Something like:

```
; DISABLE64-DAG: std {{[0-9]+}}
; DISABLE64-DAG: std {{[0-9]+}}
; DISABLE64-DAG: std {{[0-9]+}}
; DISABLE64-DAG: stdu 1,
; DISABLE64-DAG: cmplwi 3, 0

; DISABLE32-DAG: stw {{[0-9]+}}
; DISABLE32-DAG: stw {{[0-9]+}}
; DISABLE32-DAG: stw {{[0-9]+}}
; DISABLE32-DAG: stwu 1,
; DISABLE32-DAG: cmplwi 3, 0

; DISABLE-NEXT: beq 0, {{.*}}[[ELSE_LABEL:BB[0-9_]+]]
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95094/new/

https://reviews.llvm.org/D95094