[PATCH] D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 03:36:05 PST 2021


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.

One minor issue that can be fixed when merging.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp:293
+  case ISD::VECTOR_REVERSE:
+    return "vector_reverse";
   case ISD::CARRY_FALSE:                return "carry_false";
----------------
Stylistically this should be on the same line as the case to match all the other entries, even those with longer names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94883/new/

https://reviews.llvm.org/D94883



More information about the llvm-commits mailing list