[PATCH] D96409: [debug-info] refactor emitDwarfUnitLength

[ChenZheng via Phabricator via llvm-commits]

shchenz created this revision.
shchenz added reviewers: ikudrin, echristo, jsji, hubert.reinterpretcast, PowerPC.
shchenz added a project: debug-info.
Herald added subscribers: hiraditya, jgravelle-google, sbc100, dschuff.
shchenz requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

This is from code review comments in D95998 <https://reviews.llvm.org/D95998>, see https://reviews.llvm.org/D95998#2553505

comments from @ikudrin

  The idea was to remove the Lo argument from MCStreamer::emitDwarfUnitLength(Hi, Lo, Comment) so that it becomes just MCStreamer::emitDwarfUnitLength(Hi, Comment). 


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96409

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/include/llvm/MC/MCStreamer.h
  llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
  llvm/lib/CodeGen/AsmPrinter/AddressPool.cpp
  llvm/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/test/DebugInfo/X86/addr_comments.ll
  llvm/test/DebugInfo/X86/dwarf-pubnames-split.ll
  llvm/test/DebugInfo/X86/length_symbol_difference.ll
  llvm/test/MC/WebAssembly/comdat-sections.ll
  llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96409.322651.patch
Type: text/x-patch
Size: 10821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210210/27aa7ea5/attachment-0001.bin>