[PATCH] D96563: gn build: Support cross-compiling libunwind for Android.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/libunwind/src/BUILD.gn:63
   cflags_cc = [ "-fno-rtti" ]
+  defines = [ "_LIBUNWIND_IS_NATIVE_ONLY" ]
   include_dirs = [ "//libunwind/include" ]
----------------
phosek wrote:
> I'd control this by an argument, for example `libunwind_enable_cross_unwinding`, rather than setting this unconditionally to match the CMake build.
Let's wait for a use case, as premature implementation of args may constrain ourselves in the future (e.g. I wouldn't have needed to remove `libunwind_hermetic_static_library` if it hadn't existed in the first place).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96563/new/

https://reviews.llvm.org/D96563