[PATCH] D96563: gn build: Support cross-compiling libunwind for Android.

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/utils/gn/secondary/libunwind/src/BUILD.gn:63
   cflags_cc = [ "-fno-rtti" ]
+  defines = [ "_LIBUNWIND_IS_NATIVE_ONLY" ]
   include_dirs = [ "//libunwind/include" ]
----------------
I'd control this by an argument, for example `libunwind_enable_cross_unwinding`, rather than setting this unconditionally to match the CMake build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96563/new/

https://reviews.llvm.org/D96563