[PATCH] D96336: [AMDGPU] Save VGPR of whole wave when spilling

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:114
 
+// Pseudoinstruction to make a register as live, even when it isn't.
+// This is used to circumvent limitations of lifetime tracking. A VGPR can
----------------
Replace make with mark, or remove as?


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:494-495
 
+  /// When spilling SGPRs, we may need a temporary stack slot to free a VGPR.
+  Optional<int> SpillSGPRTmpIndex;
+
----------------
Why doesn't this use the normal emergency stack slot?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96336/new/

https://reviews.llvm.org/D96336