[PATCH] D96469: [AMDGPU] WIP: use single cache policy operand

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 20:10:20 PST 2021


t-tye added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIDefines.h:268-273
+enum CachePolicy {
+  GLC = 1,
+  SLC = 2,
+  DLC = 4,
+  ALL = GLC | SLC | DLC
+};
----------------
Why is ALL needed? Does the code ever deliberately want to set them all? I would suspect places only even want to set specific bits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96469/new/

https://reviews.llvm.org/D96469



More information about the llvm-commits mailing list