[PATCH] D94308: [MachineSink] SinkIntoLoop: analyse stores and aliases in between

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 03:50:11 PST 2021


SjoerdMeijer updated this revision to Diff 322941.
SjoerdMeijer added a comment.

Fixed typo.

I will look into this separately:

> Can this set the HasStoreCache for the block if it hasn't seen all the instructions in it yet?

I have uploaded D96485 <https://reviews.llvm.org/D96485> to control compile-times.

Like I said, this passes my testing. So, what do you think, good to go?
Please note this is still disabled by default.

Next step:

- the interesting bit: cost-model to decide when to sink.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94308/new/

https://reviews.llvm.org/D94308

Files:
  llvm/include/llvm/CodeGen/MachineLoopInfo.h
  llvm/lib/CodeGen/MachineLICM.cpp
  llvm/lib/CodeGen/MachineLoopInfo.cpp
  llvm/lib/CodeGen/MachineSink.cpp
  llvm/test/CodeGen/AArch64/loop-sink.mir
  llvm/test/CodeGen/X86/loop-sink.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94308.322941.patch
Type: text/x-patch
Size: 166444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210211/38a7af2a/attachment-0001.bin>


More information about the llvm-commits mailing list