[PATCH] D94308: [MachineSink] SinkIntoLoop: analyse stores and aliases in between

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 06:18:38 PST 2021


SjoerdMeijer updated this revision to Diff 322667.
SjoerdMeijer added a comment.
Herald added a subscriber: pengfei.

This fixes a miscompilation for x86 which was related to eflags setting instructions. This check was already present in MachineSink, which I can now "borrow" for the loop-sinking. This now passes a the llvm test suite on x86 and on aarch64, and also a bootstrap.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94308/new/

https://reviews.llvm.org/D94308

Files:
  llvm/include/llvm/CodeGen/MachineLoopInfo.h
  llvm/lib/CodeGen/MachineLICM.cpp
  llvm/lib/CodeGen/MachineLoopInfo.cpp
  llvm/lib/CodeGen/MachineSink.cpp
  llvm/test/CodeGen/AArch64/loop-sink.mir
  llvm/test/CodeGen/X86/loop-sink.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94308.322667.patch
Type: text/x-patch
Size: 166092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210210/e2e69bda/attachment-0001.bin>


More information about the llvm-commits mailing list