[PATCH] D94013: [libclc] Add clspv target for libclc

[Jan Vesely via Phabricator via llvm-commits]

jvesely added a comment.

It'd be nice to add an explanation why this can't reuse the existing SPIR-V targets and needs to add a new one.
Does the new FMA implementation generate significantly worse code (EG/NI + mesa-spirv should be the only users) than the original? Should it just be replaced? I assume it passes the conformance suite.



================
Comment at: libclc/CMakeLists.txt:289
 			set( spvflags --spirv-max-version=1.1 )
+		elseif( ${ARCH} STREQUAL "spir" )
+			set( build_flags )
----------------
this looks exactly like the default branch. why is a special case needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94013/new/

https://reviews.llvm.org/D94013