[PATCH] D94013: [libclc] Add clspv target for libclc

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: libclc/generic/lib/gen_convert.py:358
     print("  {DST}{N} r = convert_{DST}{N}(x);".format(DST=dst, N=size))
-    print("  {SRC}{N} y = convert_{SRC}{N}(y);".format(SRC=src, N=size))
+    print("  {SRC}{N} y = convert_{SRC}{N}(r);".format(SRC=src, N=size))
     if mode == '_rtz':
----------------
alan-baker wrote:
> tstellar wrote:
> > Why did this change?
> I can revert this since I don't use the conversion builtins, but the code this generates is obviously wrong. y is being used in its own declaration. This leads to llvm generating undefs in the conversion functions.
Ok, this would make sense as a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94013/new/

https://reviews.llvm.org/D94013