[PATCH] D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 3 inline comments as done.
clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:51
 
+def A_CharacterType : FIR_Type<"Character", "char"> {
+  let summary = "FIR character type";
----------------
mehdi_amini wrote:
> clementval wrote:
> > @mehdi_amini @rriddle I'm currently forcing this type to be generated before BoxCharType because it depends on it. Is there a better way to achieve this than adding a prefix (`A_`)? 
> Is this a matter of updating the TableGen backend to forward declare all classes before emitting the content?
> I had to do this with operations a while ago for a similar reason.
Moving the definitions in the .cpp files does the trick. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96446/new/

https://reviews.llvm.org/D96446