[PATCH] D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:63
+
+  let printer = [{
+    $_printer << "char<" << getImpl()->FKind;
----------------
Can you move the printer/parser to C++ instead? You just have to remove these fields and then you can provide your own definition for CharacterType::parse and CharacterType::print.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96446/new/

https://reviews.llvm.org/D96446