[PATCH] D96119: [Codegenprepare][X86] Use usub with overflow opt for IV increment

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 09:47:48 PST 2021


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

Still LGTM, thanks for adding the one use requested restriction and the inner loop case is a good catch too.

I'd agree that landing the new tests, then rebasing over, then committing would make post-commit review and any potential reverts easier to understand.  Optional, but encouraged.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96119/new/

https://reviews.llvm.org/D96119



More information about the llvm-commits mailing list