[PATCH] D96119: [Codegenprepare][X86] Use usub with overflow opt for IV increment

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 09:32:17 PST 2021


spatel added inline comments.


================
Comment at: llvm/test/CodeGen/X86/usub_inc_iv.ll:183-185
+  %iv.next = add i64 %iv, -1
+  %cond_0 = call i1 @use(i64 %iv.next)
+  br i1 %cond_0, label %middle, label %failure
----------------
I defer to @reames to continue the review (I don't have a good handle on the IV subtleties), but I think it would be easier to review if the test diffs are pre-committed, so we just see the minimal changes from the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96119/new/

https://reviews.llvm.org/D96119



More information about the llvm-commits mailing list