[PATCH] D94668: [debug-info] [NFC] add is-a(isa<>) support for MCStreamer

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

In D94668#2553382 <https://reviews.llvm.org/D94668#2553382>, @ikudrin wrote:

> In D94668#2553258 <https://reviews.llvm.org/D94668#2553258>, @shchenz wrote:
>
>> Gentle ping...
>>
>> We still need this patch for D95518 <https://reviews.llvm.org/D95518> for `lib/Target/PowerPC/PPCAsmPrinter.cpp` file. We need to emit the end symbol for asmstreamer to tell where is the end of the text section.
>
> That is yet another case when the patch tries to break the abstraction. It would be better to rewrite it in a more general way that avoids casting. Thus, this patch will not be needed.

Do you have any idea about how to do this? @ikudrin  My requirement here is: I need to add the `endSymbol` for asm streamer at the end of .text section to indicate the end of the text section.
Object streamer can easily do this by calling `MCSymbol *endSection(Section)` in `emitDwarfLineTable`, but this does not work for asm streamer. When we are generating assembly output for .debug_line section, we can not go back to .text section and emit an end symbol there. I think this is not supported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94668/new/

https://reviews.llvm.org/D94668