[PATCH] D94668: [debug-info] [NFC] add is-a(isa<>) support for MCStreamer

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 00:22:02 PST 2021


ikudrin added a comment.

In D94668#2553258 <https://reviews.llvm.org/D94668#2553258>, @shchenz wrote:

> Gentle ping...
>
> We still need this patch for D95518 <https://reviews.llvm.org/D95518> for `lib/Target/PowerPC/PPCAsmPrinter.cpp` file. We need to emit the end symbol for asmstreamer to tell where is the end of the text section.

That is yet another case when the patch tries to break the abstraction. It would be better to rewrite it in a more general way that avoids casting. Thus, this patch will not be needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94668/new/

https://reviews.llvm.org/D94668



More information about the llvm-commits mailing list