[PATCH] D96327: [CodeGen] Fix two dots between text section name and symbol name

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 01:05:24 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:920
     if (TM.getUniqueBasicBlockSectionNames()) {
-      Name += ".";
+      if (!Name.endswith(".")) {
+        Name += ".";
----------------
If this makes a difference, it needs a test.

And delete braces around simple one-line statements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96327/new/

https://reviews.llvm.org/D96327



More information about the llvm-commits mailing list