[PATCH] D96030: NFC: Migrate CodeMetrics to work on InstructionCost

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 02:37:17 PST 2021


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/lib/Analysis/CodeMetrics.cpp:120
   ++NumBlocks;
-  unsigned NumInstsBeforeThisBB = NumInsts;
+  // Use a proxy for NumInsts, so that it can use InstructionCost's arithmetic
+  // properties.
----------------
nit: Could you specifically mention saturation here as an example? Not sure about others, but it certainly helped me to understand the change more when I considered the saturation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96030/new/

https://reviews.llvm.org/D96030



More information about the llvm-commits mailing list