[PATCH] D96310: [llvm-objcopy] Delete --build-id-link-{dir,input,output}

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added a comment.

In D96310#2550621 <https://reviews.llvm.org/D96310#2550621>, @jhenderson wrote:

>> No longer used by Fuchsia and not used elsewhere.
>
> How can you be sure this isn't used outside Google and the LLVM upstream repo?
>
> I'm not necessarily opposed to this (it's not in our downstream users' documentation, and we don't support it in our downstream toolchain), but what are you going to do if this breaks another user when this gets released in LLVM 13? If there's a reliable alternative, that's fine by me, but I'd encourage it to be in the commit message, and probably also in release notes, so that existing users (if there are any), can know what to do instead.

I am figuring out whether we can retire `llvm/runtimes/llvm-strip-link.in`

The functionality has llvm-readelf+ln replacement. It was implemented in llvm-objcopy for its convenience. Debian Code Search tells me that no external open-source project uses the functionality.

If it is used by some proprietary users, I think the best is an llvm-dev announcement that the options will be deleted if nobody speaks up. If nobody responds, we will delete the options.



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:446
 
+  ArrayRef<uint8_t> Contents;
+
----------------
jhenderson wrote:
> This change seems unrelated?
This is natural after the last public user of Contents is deleted.

It does not seem necessary to defer it to a subsequent clean-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96310/new/

https://reviews.llvm.org/D96310