[PATCH] D96310: [llvm-objcopy] Delete --build-id-link-{dir,input,output}

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

> No longer used by Fuchsia and not used elsewhere.

How can you be sure this isn't used outside Google and the LLVM upstream repo?

I'm not necessarily opposed to this (it's not in our downstream users' documentation, and we don't support it in our downstream toolchain), but what are you going to do if this breaks another user when this gets released in LLVM 13? If there's a reliable alternative, that's fine by me, but I'd encourage it to be in the commit message, and probably also in release notes, so that existing users (if there are any), can know what to do instead.



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:446
 
+  ArrayRef<uint8_t> Contents;
+
----------------
This change seems unrelated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96310/new/

https://reviews.llvm.org/D96310