[PATCH] D96282: [CMake][AIX] Adjust plugin library externsion used on AIX

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 08:37:59 PST 2021


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:155-160
 # We use *.dylib rather than *.so on darwin.
-set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX})
+if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  set(LLVM_PLUGIN_EXT ".so")
+else()
+  set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX})
+endif()
----------------
Update comment to encompass the block.


================
Comment at: llvm/unittests/Support/DynamicLibrary/CMakeLists.txt:26
+  add_library(${NAME} MODULE
     PipSqueak.cpp
     )
----------------
The CI failure looks to be related: https://reviews.llvm.org/harbormaster/unit/view/324484/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96282/new/

https://reviews.llvm.org/D96282



More information about the llvm-commits mailing list