[PATCH] D96180: [dfsan] Refactor loadShadow

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:546
+  /// __dfsan_union_load call if any shadow is non-equal.
+  Value *loadNonFast16LabelShadowFastPath(Value *ShadowAddr, uint64_t Size,
+                                          Align ShadowAlign, Instruction *Pos);
----------------
Long name. WDYT about renaming to `loadLegacyShadowFast`?


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:552
+  /// instructions than ORing shadows individually.
+  Value *loadFast16LabelShadowFastPath(Value *ShadowAddr, uint64_t Size,
+                                       Align ShadowAlign, Instruction *Pos);
----------------
WDYT about renaming to `loadFast16ShadowFast`?


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1584
+    DomTreeNode *NewNode = DT.addNewBlock(Tail, Head);
+    for (auto Child : Children)
+      DT.changeImmediateDominator(Child, NewNode);
----------------
Please fix this lint.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96180/new/

https://reviews.llvm.org/D96180