[PATCH] D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strictwwm

[Piotr Sobczak via Phabricator via llvm-commits]

piotr added a comment.



> Is it worth adding a test to ensure old intrinsic still works?

The old intrinsic is still supported, so I agree we should keep the tests. I will add them back.

> I do start to wonder if it is should be "strictwwm" or "strict.wwm".
> However, we do have "softwqm" already, and hardware convention seems to be generally to glue words together, e.g. "readlane", "readfirstlane", etc -- so "strictwwm" is probably right.
> SOFT_WQM pseudo should probably become SOFTWQM for consistency at some point.

Yeah, I noticed that too. I agree SOFT_WQM is the odd one out. I will make it consistent in a separate change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96257/new/

https://reviews.llvm.org/D96257