[PATCH] D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strictwwm

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 19:45:14 PST 2021


critson accepted this revision.
critson added a comment.
This revision is now accepted and ready to land.

LGTM, seems to be straightforward refactor.
Is it worth adding a test to ensure old intrinsic still works?

I do start to wonder if it is should be "strictwwm" or "strict.wwm".
However, we do have "softwqm" already, and hardware convention seems to be generally to glue words together, e.g. "readlane", "readfirstlane", etc -- so "strictwwm" is probably right.
SOFT_WQM pseudo should probably become SOFTWQM for consistency at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96257/new/

https://reviews.llvm.org/D96257



More information about the llvm-commits mailing list