[PATCH] D96322: DebugInfo/Symbolize: Don't differentiate function/data symbolization

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Let's not rely on testing in compiler-rt to test llvm-symbolizer behaviour. Tests should be kept to the modules where the behaviour in question is. In this case, either DebugInfo or tools/llvm-symbolizer (probably the former in this case). I don't think it's hard to add a test case for this at all - all it needs to show is that a `DATA` directive can symbolize a function as data and `CODE` symbolizes an object as code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96322/new/

https://reviews.llvm.org/D96322