[PATCH] D96322: DebugInfo/Symbolize: Don't differentiate function/data symbolization

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: dblaikie, dvyukov, jhenderson.
Herald added subscribers: mgrang, hiraditya.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Before d08bd13ac8a560c4645e17e192ca07e1bdcd2895, only `SymbolRef::ST_Function`
symbols were used for .symtab symbolization. That commit added a `"DATA"` mode
to llvm-symbolizer which used `SymbolRef::ST_Data` symbols for symbolization.

Since function and data symbols have different addresses, we don't need to
differentiate the two modes. This patches unifies the two modes to simplify
code.

The only usage of `"DATA"` I know is in `compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp`.
The change can be checked by various sanitizer tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96322

Files:
  llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
  llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96322.322303.patch
Type: text/x-patch
Size: 5940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210209/5a1627a3/attachment.bin>