[PATCH] D96259: [AArch64] Use '//' as comment string for MSVC assembly

Mon Feb 8 11:38:40 PST 2021

mstorsjo added a comment.

In D96259#2548724 <https://reviews.llvm.org/D96259#2548724>, @tambre wrote:

> Thanks! Maybe worth a changelog entry?

I think that's a bit overkill TBH

In D96259#2548965 <https://reviews.llvm.org/D96259#2548965>, @rnk wrote:

> I guess the actual rules for the `armasm` tool that MSVC uses are documented here:
> https://developer.arm.com/documentation/dui0802/b/Via-File-Syntax/Via-file-syntax
>
>> Lines beginning with a semicolon (;) or a hash (#) character as the first nonwhitespace character are comment lines. If a semicolon or hash character appears anywhere else in a line, it is not treated as the start of a comment. For example:
>> -o objectname.axf      ;this is not a comment
>> A comment ends at the end of a line, or at the end of the file. There are no multi-line comments, and there are no part-line comments.
>
> But we want to support part-line comments, so I guess we have to use `//`.

Yes - and the armasm syntax is pretty much orthogonal here anyway.

In the same way on x86, clang-cl doesn't interpret .S files as if they were in masm format as that's something totally different (we have llvm-ml for that), and when instructed to output asm, it outputs gas-like syntax (although maybe it should produce masm-like assembly for consistency with msvc?). So in both cases, masm and armasm syntax are entirely different from what's put into or interpreted from gas-like .S assembly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96259/new/

https://reviews.llvm.org/D96259