[PATCH] D96259: [AArch64] Use '//' as comment string for MSVC assembly

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 09:39:58 PST 2021


rnk accepted this revision.
rnk added a comment.

I guess the actual rules for the `armasm` tool that MSVC uses are documented here:
https://developer.arm.com/documentation/dui0802/b/Via-File-Syntax/Via-file-syntax

> Lines beginning with a semicolon (;) or a hash (#) character as the first nonwhitespace character are comment lines. If a semicolon or hash character appears anywhere else in a line, it is not treated as the start of a comment. For example:
> -o objectname.axf      ;this is not a comment
> A comment ends at the end of a line, or at the end of the file. There are no multi-line comments, and there are no part-line comments.

But we want to support part-line comments, so I guess we have to use `//`.

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96259/new/

https://reviews.llvm.org/D96259



More information about the llvm-commits mailing list