[PATCH] D95551: [ARM] One-off identity shuffle

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:8246
+    int NonUndef = 0;
+    for (int i = 0, NumMaskElts = Mask.size(); i < NumMaskElts; ++i) {
+      if (Mask[i] == -1)
----------------
nit: shorter is:

  for (int i = 0; i < Mask.size(); ++i)


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:8247
+    for (int i = 0, NumMaskElts = Mask.size(); i < NumMaskElts; ++i) {
+      if (Mask[i] == -1)
+        continue;
----------------
Do we have a test for this? Might have missed it, but didn't see one I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95551/new/

https://reviews.llvm.org/D95551