[PATCH] D91972: Improve STRICT_FSETCC codegen in absence of no NaN

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-fcmp-no-nans-opt.ll:1
+; RUN: llc < %s -mtriple=arm64-eabi -enable-no-nans-fp-math | FileCheck %s
+
----------------
SjoerdMeijer wrote:
> Since these tests run with `-enable-no-nans-fp-math`, I am wondering what condition we are testing:
> 
>   if ((FPMO && FPMO->hasNoNaNs()) || TM.Options.NoNaNsFPMath)
> 
> I guess that is `TM.Options.NoNaNsFPMath`, so do we have/need checks for `FPMO->hasNoNaNs()`?
Ah yes, this only makes sense for regular fcmp which can have fast math flag `nnan`. Constrained fcmp cannot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91972/new/

https://reviews.llvm.org/D91972