[PATCH] D91972: Improve STRICT_FSETCC codegen in absence of no NaN

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 06:41:11 PST 2021


SjoerdMeijer added a comment.

In D91972#2548455 <https://reviews.llvm.org/D91972#2548455>, @thopre wrote:

> Don't check for instruction nonan flag since there's none for constrained fcmp

But that check seems useful for float instructions? In other words, can we keep the check for `FPMO->hasNoNaNs()`, but just add some new tests for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91972/new/

https://reviews.llvm.org/D91972



More information about the llvm-commits mailing list