[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 7 12:59:46 PST 2021


jrtc27 added a comment.

In D88389#2547481 <https://reviews.llvm.org/D88389#2547481>, @glaubitz wrote:

> In D88389#2547470 <https://reviews.llvm.org/D88389#2547470>, @jrtc27 wrote:
>
>> Still a number of outstanding style comments from earlier reviews
>
> Isn't that what Simon said in comment 5? That it's agreed on that it's not yet perfect but good to be merged.
>
> I feel like this is becoming too strict already :(.

My view is this is the kind of thing that, once it's committed, will never be fixed, so now is the time to enforce it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389



More information about the llvm-commits mailing list