[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kELFObjectWriter.cpp:63
+
+// FIXME Handle reloc differences between pre-M68020 models and successors
+unsigned M68kELFObjectWriter::getRelocType(MCContext &Ctx,
----------------
This is odd; processors shouldn't care about fixups. But regardless of the actual problem, more info would be helpful as this isn't particularly useful for anyone who doesn't already know the problem.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kInstPrinter.cpp:86
+    HalfMask = Mask >> s;
+    if (HalfMask && s != 0) {
+      O << ',';
----------------
MaskRay wrote:
> https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
> 
> Applies to many braces in this file.
Still many instances of this


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:342-344
+  while (*Beads) {
+    uint8_t Bead = *Beads;
+    Beads++;
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390