[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

Still a number of outstanding style comments from earlier reviews



================
Comment at: llvm/cmake/config-ix.cmake:414
   set(LLVM_NATIVE_ARCH X86)
+elseif (LLVM_NATIVE_ARCH STREQUAL "m68k")
+  set(LLVM_NATIVE_ARCH M68k)
----------------
This probably shouldn't be in the middle of the X86 block. Put it at the end?


================
Comment at: llvm/lib/Target/M68k/CMakeLists.txt:14
+
+# M68kCommonTableGen must be defined
+add_public_tablegen_target(M68kCommonTableGen)
----------------
Comment doesn't seem particularly useful


================
Comment at: llvm/lib/Target/M68k/CMakeLists.txt:17
+
+# M68kCodeGen should match with LLVMBuild.txt M68kCodeGen
+add_llvm_target(M68kCodeGen
----------------
LLVMBuild.txt is no more


================
Comment at: llvm/lib/Target/M68k/CMakeLists.txt:37
+
+# Should match with "subdirectories =  MCTargetDesc TargetInfo" in LLVMBuild.txt
+add_subdirectory(TargetInfo)
----------------
Ditto


================
Comment at: llvm/lib/Target/M68k/M68k.td:93-94
+  let InstructionSet = M68kInstrInfo;
+  // let AssemblyParserVariants = [ATTAsmParserVariant, IntelAsmParserVariant];
+  // let AssemblyWriters = [ATTAsmWriter, IntelAsmWriter];
+}
----------------
Commented-out code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389