[PATCH] D95363: [SVE][LoopVectorize] Add support for scalable vectorization of loops with vector reverse

[Caroline via Phabricator via llvm-commits]

CarolineConcatto marked 3 inline comments as done.
CarolineConcatto added a comment.

Thank you all for the review. 
I believe I had addressed your comments.
I've created another patch to compute the cost for vector reverse with scalable vector.
I've removed the cast from int to double in one of the tests, so we don't need  cast fixed for this feature.
And the IR builder now has a reverse function for fixed and scalable vectors.



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-vector-reverse.ll:23
+; CHECK-NEXT:  %[[REVERSE6:.*]] = call <vscale x 8 x double> @llvm.experimental.vector.reverse.nxv8f64(<vscale x 8 x double> %[[FADD]])
+; CHECK-NEXT:  %{{.*}} = getelementptr inbounds double, double* %{{.*}}, i64 %{{.*}}
+; CHECK-NEXT:  %[[CAST:.*]] = bitcast double* %{{.*}} to <vscale x 8 x double>*
----------------
sdesmalen wrote:
> It is difficult to verify what this code is generating, and the GEPs here are actually really important to get right, so can you just check for explicit values?
I don't know if I understood what you want.
I had to change the checks.
Do you mind to show what do you like to see being checked in these tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95363/new/

https://reviews.llvm.org/D95363