[PATCH] D96193: [ELF] Rewriting the path of sample profile file for --reproduce response.txt

[Hongtao Yu via Phabricator via llvm-commits]

hoy marked an inline comment as done.
hoy added inline comments.


================
Comment at: lld/ELF/DriverUtils.cpp:182
       break;
+    case OPT_lto_sample_profile:
+      os << arg->getSpelling() << quote(rewritePath(arg->getValue())) << "\n";
----------------
MaskRay wrote:
> move to the block below
Done.


================
Comment at: lld/test/ELF/reproduce-lto.s:13
 # RUN: tar tvf repro1.tar | FileCheck %s --implicit-check-not={{.}}
+# RUN: tar xvf repro1.tar &> %t2
+# RUN: cat repro1/response.txt >> %t2
----------------
MaskRay wrote:
> hoy wrote:
> > MaskRay wrote:
> > > I don't think the output of tar is portable.
> > > 
> > > `FileCheck %s --check-prefix=RSP < repro1/response.txt`
> > I'd like to check the path in response.txt matches the path in the tar ball, or at least it is a relative path. Not sure what is a good way. Maybe I can limit the test to Linux only.
> Perhaps `xvf` is fine...
Yeah, since `tvf` is also there. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96193/new/

https://reviews.llvm.org/D96193